spartacus04 / jext-reborn

Level up your server with custom music discs - "Just like vanilla jukebox, but better!". I mantain this in my free time.
https://spartacus04.github.io/jext-reborn/
Other
35 stars 7 forks source link

[Bug]: Cannot apply server resource pack? #94

Closed 5H08 closed 1 year ago

5H08 commented 1 year ago

Describe the bug

Hi, I'm using the Skinrestorer plugin and seemingly the resource pack usage between this plugin and JEXT makes it so that the packs conflict with each other making the server resource pack set for JEXT not able to be applied. I followed a guide from another plugin (https://itemsadder.devs.beer/compatibility-with-other-plugins/compatible/skinsrestorer) and solved the issue while using the original, non-reborn JEXT. However, due to an issue of hearing disc 11 playing in the background while custom music plays, I switched to Reborn, and suddenly the resource pack cannot be applied again. The guide I followed involved installing the Resourcepack Broadcast plugin and Placeholder API.

If this helps, I've also switched the external host for the resource pack from mc-packs.net to OneDrive download API, due to the previous not being accessible for my server which is hosted in mainland China.

I used the github tool to create the pack so there should be no issues with the pack itself.

And yes I do have protocollib installed.

Steps to reproduce

  1. PaperMC, spigot
  2. Install listed plugins: Skinrestorer, JEXT, resourcepack broadcast, placeholder api (other plugins may not have any effect in this)
  3. boom

Expected behaviour

the pack should be applied successfully

Logs

No response

Server Version

1.19.3

Server Type

Spigot

Discs.json

[
  {
    "title": "Sometimes",
    "author": "Bo En",
    "duration": 300,
    "disc-namespace": "music_disc.sometimesboenzero",
    "model-data": 1,
    "creeper-drop": true,
    "lores": [],
    "loot-tables": [],
    "fragment-loot-tables": []
  },
  {
    "title": "Rolling Stone (ft. Petite Noir)",
    "author": "Danny Brown",
    "duration": 229,
    "disc-namespace": "music_disc.rollingstoneftpetitenoirdannybrownone",
    "model-data": 2,
    "creeper-drop": true,
    "lores": [],
    "loot-tables": [],
    "fragment-loot-tables": []
  },
  {
    "title": "I've Seen Footage",
    "author": "Death Grips",
    "duration": 203,
    "disc-namespace": "music_disc.iveseenfootagedeathgripstwo",
    "model-data": 3,
    "creeper-drop": true,
    "lores": [],
    "loot-tables": [],
    "fragment-loot-tables": []
  },
  {
    "title": "Happy Birthday Song",
    "author": "Various Artists",
    "duration": 65,
    "disc-namespace": "music_disc.happybirthdaysongvariousartiststhree",
    "model-data": 4,
    "creeper-drop": false,
    "lores": [],
    "loot-tables": [],
    "fragment-loot-tables": [
      "chests/village/village_plains_house",
      "chests/village/village_savanna_house",
      "chests/village/village_desert_house",
      "chests/village/village_snowy_house",
      "chests/village/village_taiga_house"
    ]
  },
  {
    "title": "DIKEMBE!",
    "author": "JPEGMAFIA",
    "duration": 183,
    "disc-namespace": "music_disc.dikembejpegmafiafour",
    "model-data": 5,
    "creeper-drop": true,
    "lores": [],
    "loot-tables": [],
    "fragment-loot-tables": []
  },
  {
    "title": "Poznań",
    "author": "Low Roar",
    "duration": 124,
    "disc-namespace": "music_disc.poznalowroarfive",
    "model-data": 6,
    "creeper-drop": true,
    "lores": [],
    "loot-tables": [],
    "fragment-loot-tables": []
  },
  {
    "title": "简单爱",
    "author": "西红",
    "duration": 150,
    "disc-namespace": "music_disc.six",
    "model-data": 7,
    "creeper-drop": true,
    "lores": [
      "[WARNING] EXPLICIT LYRICS"
    ],
    "loot-tables": [],
    "fragment-loot-tables": []
  },
  {
    "title": "D>E>A>T>H>M>E>T>A>L",
    "author": "Panchiko",
    "duration": 262,
    "disc-namespace": "music_disc.deathmetalpanchikoseven",
    "model-data": 8,
    "creeper-drop": true,
    "lores": [],
    "loot-tables": [],
    "fragment-loot-tables": []
  },
  {
    "title": "Xiu",
    "author": "Yu Su",
    "duration": 266,
    "disc-namespace": "music_disc.xiuyusueight",
    "model-data": 9,
    "creeper-drop": true,
    "lores": [],
    "loot-tables": [],
    "fragment-loot-tables": []
  },
  {
    "title": "リサフランク420 / 現代のコンピュー",
    "author": "MACINTOSH PLUS",
    "duration": 442,
    "disc-namespace": "music_disc.fourtwozeromacintoshplusnine",
    "model-data": 10,
    "creeper-drop": true,
    "lores": [],
    "loot-tables": [],
    "fragment-loot-tables": []
  }
]

Resource pack

https://api.onedrive.com/v1.0/shares/s!Au6XAL2_ludqaheZXJL9p0GQ3X0/root/content

This issue is unique

5H08 commented 1 year ago

Speculations:

  1. JEXT reborn may have some conflict with Resourcepack Broadcast since the latter seemingly stopped working after I switched from JEXT original to reborn

  2. perhaps there are some issues with the disc file being formatted as .json so it may not support special characters? I don't know, but this shouldn't have anything to do with the resource pack being applied

5H08 commented 1 year ago

image These are all my plugins

5H08 commented 1 year ago

okay figured this shit out, it is due to the issue of the external file host. Sorry if this bothers you, the issue of 11 playing in the background is solved with reborn tho, thank you for making this plugin