DAO contract topics for discussion

[SamusElderg]

Add setter for 'retire'

• Do we want this to trigger 'true' automatically on DAO upgrade? otherwise it will be stuck false on in the new DAO (has no deployer)
• Do we need a manual setter for this to flip it between true/false?

DAO._moveDao() | Retire DAO

• Should we automatically retire the DAO on _moveDao?
• ie. set retire to true

ACTIONED:

Remove 'MemberDetails' struct?

• I think this can be removed now: struct MemberDetails { bool isMember; uint weight; uint lastBlock; uint poolCount; }

Add a getter for mapPIDMember_hasVoted

• UI will need access to mapPIDMember_hasVoted so we will need a getter/helper

RULED OUT:

DAO.calcCurrentReward() | Underflow DAO.calcCurrentReward() will result in an underflow if the harvest() function is called straight after a deposit or bond. As the mapMember_lastTime is shifted 60 seconds forward; we will be doing:

• mapMember_lastTime = block.timestamp + 60
• block.timestamp - mapMember_lastTime = (-)60 This will revert so i assume its not an issue; but we might want to look at adding a require in harvest or calcCurrentReward for block.timestamp > mapMember_lastTime ?

[SamusElderg]

Partially done see: c1ec3651f627d6937403dd6dfc70478561cc99ef