spartan7777 / ConceptCompendium

Individual Project: A Compendium for Ideas
0 stars 0 forks source link

Individual Project Checkpoint 2 - Ready for Review #13

Open spartan7777 opened 2 years ago

spartan7777 commented 2 years ago

@pawaitemadisoncollege Individual Project Checkpoint 2 is ready for review.

Ms. Waite, I believe am finally ready for Checkpoint 2, and I am submitting what I have for review.

The requirements for this checkpoint were:

  1. Database designed and created.
  2. At least one DAO with full CRUD (create, read, update, delete) implemented with Hibernate.
  3. DAO is fully unit tested, Log4J is implemented.

For this Checkpoint: The database was designed and created. There are four entity specific DAOs created some with full CRUD, and others with all test methods needed (as they contain records that would never be edited or deleted). If I need to go back and create and test these methods, that can be done. These DAOS are all implemented with Hibernate.
The four entity specific DAOs are fully unit tested and Log4J is implemented.

pawaitemadisoncollege commented 2 years ago

CP2 looks very good @spartan7777.

One of the key next steps should be to implement the generic dao and remove the entity-specific daos as they are largely copy-paste code. My recommended approach to that work is

  1. Add the generic dao class to your project (you can model it after the generic dao in the fat bike trail reports demo app).
  2. Switch one unit test over to use the generic dao. I recommend changing only one method in the test at a time, making sure each one passes before moving to the next method.
  3. Once an entire unit test class is working, then begin converting each of the remaining unit tests over to use the generic dao, using a methodical, one-method-at-a-time approach and ensuring all tests continue to pass.
  4. Finally update any code that relies on the entity-specific daos to use the generic dao.