search

sparticle999 / SpaceCompany

An incremental game about Space Mining
http://sparticle999.github.io/SpaceCompany
Other
301 stars 169 forks source link

Update starData.js #427

Closed Misacek01 closed 4 years ago

Misacek01 commented 4 years ago

Hello Sparticle,

here is the updated star names list. Sorry it took so long; I had quite a lot of work the last few days. Hope I did this right and it's usable in this form.

Upon consideration, I didn't change any distances. Most are within 1-2% of the Wikipedia value anyway, so it doesn't seem worth it. Those few that are off by more would change the order of the stars, which we agreed I wouldn't do at this point.

There are a lot of "Gliese [number]" stars as a result of my edit. But Gliese is probably the most common catalog for near-Earth stars, and you used pretty much every known star within 20 ly to keep distances low. That's why a lot of those stars simply don't have more "unique" names. (Many have alternate names, but those are usually even less user-friendly than Gliese-something.)

I used MS Visual Studio Code to edit the file, so it should be formatted right. I hope I didn't bug it. :p

Best, Mike

PS: Am I supposed to put such long comments in this window, or should it just have the changelog?

Changelog: Updated some star names with more accurate or more easily remembered ones. Replaced nonexistent 'A' and 'B' names with best-guess stars at that distance.

sparticle999 commented 4 years ago

Thanks!

sparticle999 commented 4 years ago

long comments are fine in this window. Changelog is for condensed notes on what's happened

Misacek01 commented 4 years ago

Thanks!