search

spatial-go / geoos

A library provides spatial data and geometric algorithms
http://www.spatial-go.com
GNU Lesser General Public License v2.1
617 stars 130 forks source link

DBScan PointList and Center not filled #107

Closed asturm-fe closed 6 months ago

asturm-fe commented 7 months ago

I am currently looking into this library for its geospatial clustering capabilities. I tried out the DBScan but noticed, that the clusters.Cluster properties PointList and Center are not filled. It seems to me that the calls to cluster.Append(Point) and cluster.Recenter() are missing from the implementation of DBScan. While I can do this manually after the clustering, I had expected this to be done inside the clustering function.

If this is unintentional, I suppose the changes would be easy enough to make so I could provide a MR - I look forward to your answer.

xiaogu-space commented 7 months ago

We will very pleased if you can provide MR