search

spatialaudio / jackclient-python

🂻 JACK Audio Connection Kit (JACK) Client for Python :snake:
https://jackclient-python.readthedocs.io/
MIT License
131 stars 26 forks source link

Use jack_port_rename instead of deprecated jack_port_set_name #91

Closed lack closed 3 years ago

pep8speaks commented 3 years ago

Hello @lack! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 144:80: E501 line too long (82 > 79 characters) Line 145:80: E501 line too long (86 > 79 characters)

Comment last updated at 2020-08-14 21:59:43 UTC
mgeier commented 3 years ago

Thanks for this PR!

You can ignore the first case mentioned by the PEP8 bot, but can you please fix the other two?

lack commented 3 years ago

Will do!

lack commented 3 years ago

My latest changes address all the suggestions except the one about the "assert" which predates my change here.

mgeier commented 3 years ago

@HaHeho

Seems nice now. Except for maybe the @pep8speaks linter warnings.

Those lines are in the C declarations, I don't care about long lines there.

Are they updated automatically with new commits, or how does it work?

Yes.

It's a great service, I can recommend it to any Python project: https://pep8speaks.com/

The comment above (https://github.com/spatialaudio/jackclient-python/pull/91#issuecomment-672450759) tells you the last change: "Comment last updated at 2020-08-14 21:59:43 UTC". You can even look at the edit history of that comment to see all changes.