search

spatialaudio / nbsphinx

:ledger: Sphinx source parser for Jupyter notebooks
https://nbsphinx.readthedocs.io/
MIT License
450 stars 130 forks source link

HTML: Create gallery elements according to Sphinx Gallery 0.11 #666

Closed mgeier closed 1 year ago

mgeier commented 2 years ago

Closes #655.

This is incompatible to older Sphinx Gallery versions.

pep8speaks commented 2 years ago

Hello @mgeier! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 2338:80: E501 line too long (96 > 79 characters)

Comment last updated at 2022-09-02 14:44:21 UTC
mgeier commented 2 years ago

I've removed the redundant alt text, see https://github.com/sphinx-gallery/sphinx-gallery/issues/998.

mgeier commented 1 year ago

I'm leaning towards dropping this PR, see https://github.com/mgeier/nbsphinx/pull/2 for discussion.

mgeier commented 1 year ago

See #706 for a potential alternative.

mgeier commented 1 year ago

I've merged #706, which makes this PR obsolete.