DOC: link to a local file name with spaces

spatialaudio / nbsphinx

:ledger: Sphinx source parser for Jupyter notebooks

https://nbsphinx.readthedocs.io/

MIT License

450 stars 130 forks source link

DOC: link to a local file name with spaces #699

Open mgeier opened 1 year ago

smith-kyle commented 7 months ago

I'm a little late to the party, but I noticed you all aren't using a notebook review tool and wanted to invite you to review this pull request with GitNotebooks: https://gitnotebooks.com/spatialaudio/nbsphinx/pull/699

It lets you do things like comment on rendered markdown and code cells, so might be an easy win for your PR reviews.

mgeier commented 7 months ago

Thanks for the hint @smith-kyle!

Ironically, the link that this PR is all about doesn't seem to work on the service. None of the internal links seem to work, nor does math, tables, <div> elements or links within them.

smith-kyle commented 7 months ago

I appreciate the feedback @mgeier! Latex equations, and github flavored tables will be supported soon