search

spatialaudio / nbsphinx

:ledger: Sphinx source parser for Jupyter notebooks
https://nbsphinx.readthedocs.io/
MIT License
458 stars 131 forks source link

Import CellExecutionError from nbconvert from the right place #772

Closed HealthyPear closed 9 months ago

HealthyPear commented 11 months ago

newer versions of nbconvert now define CellExecutionError only from nbconvert.preprocessors

I guess also a test is missing which made this part of code never trigger the crash ( I get it because in my sphinx build something is triggering it)

mgeier commented 11 months ago

Thanks for this PR!

If we want to be very clear, we should change the dependency in setup.py to nbconvert>=5.3,!=5.4, because this was added in https://github.com/jupyter/nbconvert/commit/c62f6e4cd5d666a435b4e59ded6fc35b1cb81f87.

BTW, I still have to figure out the CI failure, but it has nothing to do with your changes.

HealthyPear commented 11 months ago

Thanks for this PR!

If we want to be very clear, we should change the dependency in setup.py to nbconvert>=5.3,!=5.4, because this was added in jupyter/nbconvert@c62f6e4.

will do

BTW, I still have to figure out the CI failure, but it has nothing to do with your changes.

I see that the error has to do with the absence of pkg_resources. As far as I know that dependency to deal with resources is deprecated in recent python versions in favor of importlib_resources.

HealthyPear commented 11 months ago

The CI issues seem gone anyway

mgeier commented 9 months ago

The CI error has been fixed (or rather worked-around) in #773.

Can you please re-base?

HealthyPear commented 9 months ago

The CI error has been fixed (or rather worked-around) in #773.

Can you please re-base?

Done.

mgeier commented 9 months ago

Thanks!