search

spatialdude / homebridge-ecowitt

A Homebridge plugin supporting a wide range of Ecowitt sensors
https://www.npmjs.com/package/homebridge-ecowitt
Apache License 2.0
12 stars 18 forks source link

Naming of the WH32 sensor and others in the plugin configuration #4

Open mbrowny opened 3 years ago

mbrowny commented 3 years ago

Is your feature request related to a problem? Please describe:

In the plugin configuration the WH32 sensor is called: Indoor Thermometer/Hygrometer/Barometer Sensor But on the ecowitt website: https://www.ecowitt.com/shop/goodsDetail/52 it is described as: "Outdoor Temperature and Humidity Sensor (WH32)"

Also include the sensor types in the other descriptions.

Describe the solution you'd like: Suggest to rename the "Indoor Thermometer/Hygrometer/Barometer Sensor" to "Outdoor Temperature/Humidity Sensor" and add the sensor type in a bracket.

Additional context: Would be easier for someone installing the plugin to understand which sensor it actually is.

spatialdude commented 2 years ago

@mbrowny The problem I had when developing the plugin was that the data payload doesn't always clearly detail the types of sensors the data is coming from as you can see in the example in https://github.com/spatialdude/homebridge-ecowitt/issues/2#issuecomment-944851871

In my case I have two installations. A GW1000 connected to an older style WH24 like this one image and HP2551 with the newer outdoor sensors like this one WS image, both with additional other sensors.

I have a range of, but not all of, the sensors that Ecowitt sells so have tried to figure out how to interpret the data payload relationship to sensors based on available information.

I remember at the time being a little confused about the WH32 and the details on the website as you also point out. The indoor sensor that came with this system https://www.ecowitt.com/shop/goodsDetail/1 is a WH32 (I need to confirm this but am away from the installation to be sure).