spatialillusions / mil-std-2525

MIT License
23 stars 12 forks source link

Rename column in Land Civilian modifiers from Capability to Category #15

Open spatialillusions opened 1 year ago

spatialillusions commented 1 year ago

Would be a breaking change, but would unify all tables. What do you think?

kjellmf commented 1 year ago

Making breaking changes are fine as long as you update the major version accordingly. I use data from your standards libraries in orbat-mapper, but rename several of the columns/keys internally like this:

const mappings = {
    "symbolset": "symbolSet",
    "Entity": "entity",
    "Entity Type": "entityType",
    "Entity Subtype": "entitySubtype",
    "Code": "code",
    "Remarks": "remarks",
    "modifier1" : "modifierOne",
    "modifier2" : "modifierTwo",
    "First Modifier": "modifier",
    "Second Modifier": "modifier",
    "Geometric Rendering": "geometry",
    "Capability": "category",
    "Category": "category",
}

The reason I do this is to make the data slightly easier to work with in code. Example:


const label = symbol["Entity Subtype"] || symbol["Entity Type"] || symbol["Entity"];

// vs

const label = symbol.entitySubtype || symbol.entityType || symbol.entity;