search

spatialillusions / milsymbol

Military Symbols in JavaScript
www.spatialillusions.com/milsymbol
MIT License
561 stars 137 forks source link

replace ms._scale and ms._translate #165

Open spatialillusions opened 6 years ago

spatialillusions commented 6 years ago

All icons that uses these functions should be replaced with updated symbol geometries, this will speed up the canvas rendering.

fabanc commented 6 years ago

As an example, if we look at the icon GR.IC.ENGINEER used in src\numbersidc\sidc\landequipment.js. It is sometimes used with a scale factor of 0.6 or 0.7, depending on the scenario. We would need to create at least 2 new symbols. How do you envision the naming convention?

From src\numbersidc\sidc\landequipment.js: line 271: ms._scale(0.7, icn["GR.IC.ENGINEER"]) should the new symbol be named GR.IC.ENGINEER_SC0.7? line 329, 333, 344: ms._scale(0.6, icn["GR.IC.ENGINEER"]) should the new symbol be named GR.IC.ENGINEER_SC0.6?