isValid returns false

[r3mi]

In my tests, Symbol.isValid seems to always return false. Example:

var ms = require("milsymbol");

var symbol = new ms.Symbol("SFGPUCI----D");
console.log(symbol.isValid(true));
console.log(symbol.isValid());

Result:

{ drawInstructions: false, icon: true, mobility: true }
false

I would expect true for such a valid SIDC. Am I missing something ?

[spatialillusions]

I'm not able to reproduce this at the moment, what version of milsymbol were you using?

[r3mi]

Version 1.3.3 , through NPM

var ms = require("milsymbol");

console.log(ms.getVersion());

var symbol = new ms.Symbol("SFGPUCI----D");
console.log(symbol.isValid(true));
console.log(symbol.isValid());

gives

milsymbol.js 1.3.3 - Copyright (c) 2017 Måns Beckman  http://www.spatialillusions.com
1.3.3
{ drawInstructions: false, icon: true, mobility: true }
false

[spatialillusions]

Fixed in major branch.