search

spatialillusions / milsymbol

Military Symbols in JavaScript
www.spatialillusions.com/milsymbol
MIT License
544 stars 133 forks source link

ES6 errors #223

Closed scottnc27603 closed 1 year ago

scottnc27603 commented 5 years ago

I ran into some issues with adding milsymbol to a React application. Apparently all of the import calls need to be at the start of the file? Anyway, I can submit a PR, but it appears that I'm unable to create a branch?

spatialillusions commented 5 years ago

There shouldn't be anything that prevents you from making a fork... The reason could be that you already have an old fork of milsymbol as one of your repositories. Could you try to remove the old fork and fork it again?

scottnc27603 commented 5 years ago

10-4 Mans, thanks for all of your hard work! I'm trying to figure out how to modify everything for the latest eslint without going through all of the code

On Tue, Sep 3, 2019 at 2:42 PM Måns Beckman notifications@github.com wrote:

There shouldn't be anything that prevents you from making a fork... The reason could be that you already have an old fork of milsymbol as one of your repositories. Could you try to remove the old fork and fork it again?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/spatialillusions/milsymbol/issues/223?email_source=notifications&email_token=AAJYBXIRHLXGO2OU5VPS5FTQH2VZBA5CNFSM4IN5C3F2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5ZFMGA#issuecomment-527586840, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJYBXOAPL7TYLPEHLLLFYDQH2VZBANCNFSM4IN5C3FQ .

spatialillusions commented 4 years ago

Could it be that you cant fork the library because you already have an old fork?

scottnc27603 commented 4 years ago

I did see that there was a es6 branch after sending the message. Our funds for the project have been on hold for a while, so I haven't had a need to deal with the issue. I may get back to this issue early next year.

Scott

On Fri, Oct 25, 2019 at 12:14 PM Måns Beckman notifications@github.com wrote:

Could it be that you cant fork the library because you already have an old fork?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/spatialillusions/milsymbol/issues/223?email_source=notifications&email_token=AAJYBXOVYIAHAGQAHU6I2NDQQMLORA5CNFSM4IN5C3F2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECI2T2A#issuecomment-546417128, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJYBXMOWWTIH7XFUXIIP3TQQMLORANCNFSM4IN5C3FQ .