spatialmodel / inmap

InMAP reduced-form air quality model for fine particulate matter (PM2.5)
GNU General Public License v3.0
61 stars 42 forks source link

clarify mapping of mortality rates to population groups #27

Closed dpaolella closed 7 years ago

dpaolella commented 7 years ago

Code and configuration file were changed so that mortality rates are mapped to population groups, rather than the other way around. This makes more sense and eliminates the possibility for users to map a mortality rate to multiple population groups (this would result in a confusing error in the current code).

ctessum commented 7 years ago

...and making sure the tests pass

ctessum commented 7 years ago

Also, please make sure these changes are reflected in all of the .toml configuration files in the "eval" directory.

dpaolella commented 7 years ago

Ok, are all the configuration files in the "eval" directory still being used?

ctessum commented 7 years ago

It looks like configExampleSR.toml isn't being used, so that one can perhaps be deleted. The other ones are being used.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 81.187% when pulling 70d98897580f1dc3d2213029bd813a98d60c4727 on mortData into 248ef5f243fc815f4c14a314a778f6466c365d58 on master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 81.187% when pulling fc43b1fe4d4d57e0375265f69a1f45316ce171f7 on mortData into 248ef5f243fc815f4c14a314a778f6466c365d58 on master.