search

spatialmodel / inmap

InMAP reduced-form air quality model for fine particulate matter (PM2.5)
GNU General Public License v3.0
61 stars 42 forks source link

Variable order does not match in preproc.go #40

Closed jlbeidler closed 6 years ago

jlbeidler commented 6 years ago

The order of the variables returned from the marginalPartitioning function in preproc.go does not match the order of variables in the function calls from lines 221-246. This is in the master branch.

ctessum commented 6 years ago

Thanks for raising this issue. It looks like it was introduced in 22794157d7adb955e1e40b8eded72530bacf745f, so it doesn't affect any of the publicly available input data, which was all created before that change, or any published results, which have all been based on the previously created data.

I will create a pull request in a couple minutes, would you be willing to confirm that it resolves the issue?

jlbeidler commented 6 years ago

I confirmed that this fixes the issue. Thanks!