search

spatialmodel / inmap

InMAP reduced-form air quality model for fine particulate matter (PM2.5)
GNU General Public License v3.0
59 stars 41 forks source link

Fixed geos-chem inverse density #75

Closed SumilThakr closed 5 years ago

SumilThakr commented 5 years ago

Alt is now returning the inverse air density instead of just the density.

Please take a look.

ctessum commented 5 years ago

Also, try running go test -regen_golden_files to make it so the tests pass.

https://github.com/spatialmodel/inmap/blob/master/preproc_test.go#L39

ctessum commented 5 years ago

Looking good. It looks like the tests are still failing, though. Is there a second golden file that needs to be regenerated? Do the tests pass on your machine?

Also, in most cases we want there to be 1 commit for each pull request. Here's an example of how to squash multiple commits into 1. Ideally we also want the commit message to be more descriptive, for example including the fact that the fix is specific to the GEOS-Chem prepocessor. Then you can use git push -f to force the squashed and renamed commit on your machine to replace the multiple commits here.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 67.551% when pulling db1834e8691c149863dd7c40e5d056a10f37f6b8 on SumilThakr:altfix into 86ec0501f09380f634ef69de536795235684d2c0 on spatialmodel:master.

ctessum commented 5 years ago

Thanks!