Closed SumilThakr closed 5 years ago
Also, try running go test -regen_golden_files
to make it so the tests pass.
https://github.com/spatialmodel/inmap/blob/master/preproc_test.go#L39
Looking good. It looks like the tests are still failing, though. Is there a second golden file that needs to be regenerated? Do the tests pass on your machine?
Also, in most cases we want there to be 1 commit for each pull request. Here's an example of how to squash multiple commits into 1. Ideally we also want the commit message to be more descriptive, for example including the fact that the fix is specific to the GEOS-Chem prepocessor. Then you can use git push -f
to force the squashed and renamed commit on your machine to replace the multiple commits here.
Thanks!
Alt is now returning the inverse air density instead of just the density.
Please take a look.