UTY-2606: Improve entity system

BryanJY-Wong commented 4 years ago

Description

Refactor EntitySystem to use a more Data-Oriented approach.
Breaking change, EntitiesAdded + EntitiesRemoved are now properties and returns NativeList<EntityId> instead of List<EntityId>

Tests

Unit Tests in Assets/Tests/EditmodeTests/Core/EntitySystemTests.cs
Launched local deployment and spawn cubes

Documentation

[x] Changelog

Primary reviewers

If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.

improbable-prow-robot commented 4 years ago

Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UTY-2606

zeroZshadow commented 4 years ago

As there is only 1 system actually using the "added" and "removed" entities, would it not be better to remove the EntitiesSystem and move that functionality into the 1 system user the data?

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

84.9% Coverage
0.0% Duplication

spatialos / gdk-for-unity