search

spatialos / gdk-for-unity

SpatialOS GDK for Unity
https://gdk.improbable.io/spatialos-gdk-unity
MIT License
355 stars 77 forks source link

Remove entity query loop from `SendCreatePlayerRequestSystem`. #1497

Closed jamiebrynes7 closed 3 years ago

jamiebrynes7 commented 3 years ago

Entity queries cannot have component level permissions in v15, so this system should not use them otherwise we require clients to have full query permissions over the deployment.

I additionally refactored the system to move all the stateful parts into a separate class, this makes it easier to reason about (imo).

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication