search

spatialos / gdk-for-unity

SpatialOS GDK for Unity
https://gdk.improbable.io/spatialos-gdk-unity
MIT License
355 stars 77 forks source link

Space character in path will cause sdk download failure #387

Closed filod closed 6 years ago

filod commented 6 years ago

We are accepting issues and we want your feedback.

Description

can not retrieve worker sdk when starter kit in a path which have space in folder name.

Expected behaviour

retrieve worker

Current behaviour

only a tip from unity log: "Failed to download SpatialOS Core Sdk version XXX..."

Possible solution

  1. make target saving path encoding right
  2. suggestion: more readable error msg from process output (i can't see any stdout msg form unity's console, this make my debugging so hard)

Steps to reproduce

download the starterkit in a path with space in it (like D:\game dev), then open unity editor.

Environment

windows 10

samiwh commented 6 years ago

Thanks for raising this @filod. A ticket has been raised and this should be fixed soon.

samiwh commented 6 years ago

Hi @filod, which GDK commit do you have checked out?

filod commented 6 years ago

i checked GDK from git releases tab here https://github.com/spatialos/UnityGDK/releases/tag/starter-project

filod commented 6 years ago

Also btw, i have problem with launching SpatialOS from web console, seems right now i can not download client.zip from it. i get this if i download it directly: image

so, where should i issue this ? the GDK repo? SpatialOS forum ?

samiwh commented 6 years ago

It seems like the directory name issue was fixed after that tag. Currently we don't have a proper release process are using the branch pinned/starter-project for use with other projects, or just use master. We will probably remove that tag as it isn't really a release :.

For the client zip issue, did you build the client worker before uploading the assembly? It should create an artifact called UnityClient@Windows.zip.

samiwh commented 6 years ago

Generally the SpatialOS forums are the best place to raise errors; they are more easily searchable for others having the same problem. However we will deal with issues raised here too :).