spatialtopology / spacetop-prep

code for transferring data and preprocessing
MIT License
1 stars 3 forks source link

[BUG] sub-0088_ses-03_task-social_run-03 negative onset #103

Open jungheejung opened 3 months ago

jungheejung commented 3 months ago

Which module is this from?

beh

What is the issue?

(Write your answer here.)

What was your expected behavior?

onsets are either 0 or positive values

How can we reproduce this?

check sub-0088/ses-03/func/sub-0088_ses-03_task-social_ac1-mb8_run-03_events.tsv

Any additional context?

This is a cognitive run. The negative onsets occur when invalid trials are included in the calculation of the difference in onset time relative to the initial scan start time. The solution is to remove invalid trials before calculating onset times

jungheejung commented 2 months ago

@Zizhuang-Miao task-narrative sub-0064, ses-02, run-01 also has a negative onset. Could you please check where this is coming from the narratives task?

Zizhuang-Miao commented 2 months ago

There is no negative onset for sub-0064_ses-02_task-narratives_run01, but a negative duration for the first "expectation_mouse_trajectory" trial type. That's because the duration for a mouse trajectory was imputed by subtracting mouse trajectory onset time (imputed from mouse trajectory recorded in .mat files) from reaction time (recorded by event0x_RT in the .csv files saved). The narratives dataset has a problem of recording an extra 0.5 seconds of mouse trajectories if participants' response time < 3.5s (the trial duration was set as 4s); if we imputed mouse trajectory onset time by finding when participants first moved their mouse, there was one scenario when the imputed onset time could be larger than reaction time and resulted in a negative duration for mouse trajectories -- when participants did not move the mouse before clicking, and then moved the mouse some time between 3.5-4 seconds. It could be fixed by updating the beh-preproc.csv file and run the events_narratives.py again.

When do you expect it to be done? Will it work if I update the folder /dartfs-hpc/rc/lab/C/CANlab/labdata/data/spacetop/events_files with new events files for task-narratives and you merge them to /dartfs-hpc/rc/lab/C/CANlab/labdata/data/spacetop/dartmouth?