spatialtopology / spacetop-prep

code for transferring data and preprocessing
MIT License
1 stars 3 forks source link

[BUG] erroneously deleted files SUSPICIOUSLY_LONG_EVENT_DESIGN #110

Open jungheejung opened 2 months ago

jungheejung commented 2 months ago

Which module is this from?

beh, func

What is the issue?

    [WARNING] SUSPICIOUSLY_LONG_EVENT_DESIGN The onset of the last event is after the total duration of the corresponding scan.
This design is suspiciously long.

        /sub-0004/ses-02/func/sub-0004_ses-02_task-faces_acq-mb8_run-01_bold.nii.gz
        /sub-0005/ses-04/func/sub-0005_ses-04_task-fractional_acq-mb8_run-01_bold.nii.gz

        12 more files with the same issue

What was your expected behavior?

/sub-0004/ses-02/func/sub-0004_ses-02_task-faces_acq-mb8_run-01_bold.nii.gz

How can we reproduce this?

(Write your answer here.)

Any additional context?

@yarikoptic I believe we checked the unredacted branch. Could we revisit this on meeting of Sep 20th?

yarikoptic commented 1 month ago
❯ jq -r '.issues.issues[] | select(.code == "SUSPICIOUSLY_LONG_EVENT_DESIGN") | .location' deno-bids-validator.json

/sub-0004/ses-02/func/sub-0004_ses-02_task-faces_acq-mb8_run-01_bold.nii.gz
/sub-0005/ses-04/func/sub-0005_ses-04_task-fractional_acq-mb8_run-01_bold.nii.gz
/sub-0011/ses-02/func/sub-0011_ses-02_task-narratives_acq-mb8_run-02_bold.nii.gz
/sub-0013/ses-04/func/sub-0013_ses-04_task-fractional_acq-mb8_run-01_bold.nii.gz
/sub-0017/ses-02/func/sub-0017_ses-02_task-alignvideo_acq-mb8_run-01_bold.nii.gz
/sub-0017/ses-04/func/sub-0017_ses-04_task-social_acq-mb8_run-04_bold.nii.gz
/sub-0025/ses-03/func/sub-0025_ses-03_task-shortvideo_acq-mb8_run-01_bold.nii.gz
/sub-0026/ses-03/func/sub-0026_ses-03_task-shortvideo_acq-mb8_run-01_bold.nii.gz
/sub-0035/ses-01/func/sub-0035_ses-01_task-alignvideo_acq-mb8_run-02_bold.nii.gz
/sub-0055/ses-02/func/sub-0055_ses-02_task-narratives_acq-mb8_run-04_bold.nii.gz
/sub-0061/ses-01/func/sub-0061_ses-01_task-alignvideo_acq-mb8_run-03_bold.nii.gz
/sub-0069/ses-02/func/sub-0069_ses-02_task-narratives_acq-mb8_run-03_bold.nii.gz
/sub-0084/ses-03/func/sub-0084_ses-03_task-alignvideo_acq-mb8_run-01_bold.nii.gz
/sub-0126/ses-01/func/sub-0126_ses-01_task-alignvideo_acq-mb8_run-01_bold.nii.gz
jungheejung commented 1 month ago

TRUE ERROR: RESOLVED SWAPPED DUPS

EXPLORE

TRUE ERROR: DO NOTHING but these runs are shorter than expected - Why is the error flagging Long event design?

FALSE ALARM

: Run length exactly matches the intended TR length. Not sure why the validator raised flags on this bold file.

jungheejung commented 1 month ago

@yarikoptic

jungheejung commented 1 month ago
yarikoptic commented 1 month ago

if you know that there were no events for data points, I would just remove those events from _events files

jungheejung commented 1 month ago

@yarikoptic Thanks for the quick response!

There are some arbitrary cases - all ears to hear your thoughts. sub-0013_ses-04_task-fractional_acq-mb8_run-01_events.tsv for example

My intuition is remove events.tsv rows where participants do not respond, but this will lead in a discrepancy between BOLD and events.tsv either way.