Open spacetop-admin opened 2 years ago
Ah, you're so right. thanks for catching that. I git added in that branch and when tried to switch and commit, I realized I screwed up.
What would be your recommendation - do I revert back?
From: Yaroslav Halchenko @.> Sent: Thursday, March 24, 2022 12:57 PM To: spatialtopology/preprocessing @.> Cc: Hee Jung Jung @.>; Author @.> Subject: Re: [spatialtopology/preprocessing] script to remove dups from intendedfor (PR #28)
@jungheejunghttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjungheejung&data=04%7C01%7CHee.Jung.Jung.GR%40dartmouth.edu%7Ca0f70333f43f4d095f5c08da0db75461%7C995b093648d640e5a31ebf689ec9446f%7C0%7C0%7C637837378299515430%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=TGErAmonrIP%2Br8yGsVSHtmWuHVsIo6mGiu9GTaVlrBM%3D&reserved=0 Ideally you should have switched to the main branch (master) for unrelated to this PR (script to remove dups...) changes, and commit there so this PR would correspond only to the single feature related to this PR.
— Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fspatialtopology%2Fpreprocessing%2Fpull%2F28%23issuecomment-1077836930&data=04%7C01%7CHee.Jung.Jung.GR%40dartmouth.edu%7Ca0f70333f43f4d095f5c08da0db75461%7C995b093648d640e5a31ebf689ec9446f%7C0%7C0%7C637837378299515430%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=JKoNpeBGWkvfK2K0HQXRiX8%2FmGMo5NzHMsfSSMdf6vA%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAM6ZNUWG2WHEHWSK63MPCBLVBSNGFANCNFSM5ROEKS6A&data=04%7C01%7CHee.Jung.Jung.GR%40dartmouth.edu%7Ca0f70333f43f4d095f5c08da0db75461%7C995b093648d640e5a31ebf689ec9446f%7C0%7C0%7C637837378299515430%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=3j7hyYJI7IogfhEHvXMGH51%2FAQWv2c2KI%2FRN2U%2FAToo%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>
not really "Revert" -- let's do tomorrow in CLInic (add to the agenda plz)? and meanwhile can continue working in this branch, just make sure having separate commits for separate "pieces" -- it will be easy to split it all apart later on.
Sounds great. Will do so. Thank you!
From: Yaroslav Halchenko @.> Sent: Thursday, March 24, 2022 1:58 PM To: spatialtopology/preprocessing @.> Cc: Hee Jung Jung @.>; Author @.> Subject: Re: [spatialtopology/preprocessing] script to remove dups from intendedfor (PR #28)
not really "Revert" -- let's do tomorrow in CLInic? and meanwhile can continue working in this branch, just make sure having separate commits for separate "pieces" -- it will be easy to split it all apart later on.
— Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fspatialtopology%2Fpreprocessing%2Fpull%2F28%23issuecomment-1077892736&data=04%7C01%7CHee.Jung.Jung.GR%40dartmouth.edu%7C89c0e5b3cb574dae53c608da0dbfe7ae%7C995b093648d640e5a31ebf689ec9446f%7C0%7C0%7C637837415127394047%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=bdrZDF6eeeKhzZsQid4pwXFkPCfYkJMi%2FRurOTBl8YI%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAM6ZNURSFUCB3Z77V6QPHELVBSUMLANCNFSM5ROEKS6A&data=04%7C01%7CHee.Jung.Jung.GR%40dartmouth.edu%7C89c0e5b3cb574dae53c608da0dbfe7ae%7C995b093648d640e5a31ebf689ec9446f%7C0%7C0%7C637837415127394047%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=xFLlxRr%2F%2FuRHhEaS4VGAsTgP9TqiiQo2uW97Ray8oDQ%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>
@all-contributors please add @yarikoptic for infrastructure, tests and code
@spacetop-admin
I've put up a pull request to add @yarikoptic! :tada:
@jungheejung Ideally you should have switched to the main branch (master) for unrelated to this PR (script to remove dups...) changes, and commit there so this PR would correspond only to the single feature related to this PR.