search

spatialtopology / spacetop-prep

code for transferring data and preprocessing
MIT License
0 stars 3 forks source link

Pull Request for generalizability templates #44

Open Michael-Sun opened 1 year ago

Michael-Sun commented 1 year ago

Study generalizability templates generated for: fmriprepgr generate_pdf boldcorrelation/qc01_saveniinumpy boldcorrelation/qc01_SLURM boldcorrelation/qc02_SLURM fdmean/fdmean_painruns fdmean/fdmean_SUBMIT

yarikoptic commented 1 year ago

why to commit all the logs from all the jobs? did you look at the diff for the commits?

Michael-Sun commented 1 year ago

why to commit all the logs from all the jobs? did you look at the diff for the commits?

Good catch! So there are a number of logs to consider here, there are remnants of datalad, fmriprep, and mriqc that were probably committed and leftover by @jungheejung. I think those should be deleted and I have removed them from my branch, but she'll make the ultimate decision about whether or not to leave it in master. Then there are wasabi_physio logs that were left in there by me, which have now been removed.

Michael-Sun commented 1 year ago

@yarikoptic I'm noticing that the current pull-request includes 7 commits that are relevant for the WASABI project but not for Spacetop, and only the latest commit is relevant for Spacetop. How should I go about completing this pull request, should I do git cherry-pick?

yarikoptic commented 1 year ago

you can cherry-pick into a new branch or if you just want to discard some but not the other in this branch, can do interactive rebase like git rebase -i HEAD~7 and leave only the one(s) you want