Issue with SIGCHLD handling in PHP Version 8.1.24

spatie / async

Easily run code asynchronously

https://spatie.be/en/opensource/php

MIT License

2.65k stars 179 forks source link

Issue with SIGCHLD handling in PHP Version 8.1.24 #217

Closed sibadevelopment closed 9 months ago

sibadevelopment commented 1 year ago

The pcntl signal handling is not working in PHP Version 8.1.24.

I don't know what is planned in future PHP versions but I would recommend to change the following line

if (phpversion() === '8.1.22' || phpversion() === '8.2.9')

to this:

if (version_compare(PHP_VERSION, '8.1.22') >= 0 || version_compare(PHP_VERSION, '8.2.9') >= 0)

matthi4s commented 1 year ago

The issue that is fixed in the lines that you are referring to is only specific to those two versions. It was reverted in PHP 8.1.23 and therefore the workaround should not be necessary or work in any other version.

sibadevelopment commented 1 year ago

I have read from that it should be reverted with PHP version 8.1.23. But for me it's not working without the fix on a Ubuntu machine with PHP 8.1.24 (cli) (built: Oct 6 2023 09:46:42) (NTS) 8.1.24. So was it changed again from version 8.1.23 to version 8.1.24?

spatie-bot commented 9 months ago

Dear contributor,

because this issue seems to be inactive for quite some time now, I've automatically closed it. If you feel this issue deserves some attention from my human colleagues feel free to reopen it.