spatie / blender

The Laravel template used for our CMS like projects
https://freek.dev/on-open-sourcing-blender
876 stars 148 forks source link

Enumerator interface as contract #344

Closed ludo237 closed 7 years ago

ludo237 commented 7 years ago

Hello

I would like to propose this changes for Blender as my first contribution to this project, which I find interesting.

What is all about ?

This is the first implementation for a structure that allows enumerators to exists like in other programming languages such as c# or elixir.

The main goal is to provide a common layer for every future enumerators in order to use the same API across all the application.

Why matters ?

PHP does not have a good enumerator implementation. There are a lot of implementations of it but either they are old or they have been implemented in a weird way, without even tests.

Why bothering create a new one?

Enumerator are powerful and they need to be implemented with the best standard possible. I'm referring myself to .NET and Elixir in particular

Tasks

freekmurze commented 7 years ago

Hi,

thank you for this PR. My feeling is that if you want to build a modern enumerator it should be grown in package land and not inside Blender.

A good enumerator package is actually one our list with package ideas, but we haven't made one yet because other ideas were more important for our projects.