search

spatie / calendar-links

Generate add to calendar links for Google, iCal and other calendar systems
https://spatie.be/opensource
MIT License
914 stars 148 forks source link

Add support for outlook.office365.com ->webOffice365() #134

Closed gulios closed 2 years ago

gulios commented 3 years ago

Context and Purposes

dravenk commented 2 years ago

This is exactly what I need. outlook.live.com doesn't work in the company's email, so we need to use office365.com

dravenk commented 2 years ago

When I was testing, I sometimes lost data using office365.com, and office365.com redirected to office.com. We probably need to investigate whether office365.com or office.com supports adding calendars from url.

dravenk commented 2 years ago

There is no official documentation. https://github.com/InteractionDesignFoundation/add-event-to-calendar-docs/blob/main/services/outlook-web.md

dravenk commented 2 years ago

@gulios I haven't been able to find a url to add a calendar to Office365, but I checked Microsoft's official documentation that the domain name used to add a calendar to outlook is outlook.office.com. Please change outlook.office365.com to outlook.office.com. https://docs.microsoft.com/en-us/previous-versions/office/office-365-api/api/version-2.0/calendar-rest-operations

gulios commented 2 years ago

@gulios I haven't been able to find a url to add a calendar to Office365, but I checked Microsoft's official documentation that the domain name used to add a calendar to outlook is outlook.office.com. Please change outlook.office365.com to outlook.office.com. https://docs.microsoft.com/en-us/previous-versions/office/office-365-api/api/version-2.0/calendar-rest-operations

ok, tested with outlook.office.com and it works. I'll change this PR.

dravenk commented 2 years ago

@gulios gulios Hi, I saw that the domain name of PR has not been updated. Do you still update this PR?

gulios commented 2 years ago

@gulios gulios Hi, I saw that the domain name of PR has not been updated. Do you still update this PR?

not yet, I don't have time now for this ;( methods names should be changed too.

dravenk commented 2 years ago

@gulios I have been working on this feature recently. Since I cannot modify this PR, I have re-opened a PR that includes your submission, please do not mind, and thank you. Move to Issue discussion https://github.com/spatie/calendar-links/issues/145 PR https://github.com/spatie/calendar-links/pull/146

alies-dev commented 2 years ago

Hey @gulios and @dravenk

In v1.7 we support both https://outlook.office.com and https://outlook.live.com. Do we still need to support https://outlook.office365.com, what do you think? i'm not a user of all these domains/services, I'm a bit confused how many of them should we support.

gulios commented 2 years ago

I think outlook.office.com is fine because it works form me too.

Thank you. I'll test it when have a time.

gulios commented 2 years ago

but no.... ;(

it doesn't work for all account types ;(

https://outlook.office365.com doesn't work for personal accounts

https://outlook.office.com same....

don;t get why M$ has a problems like this ;(

@dravenk can you check it for office350 and personal accounts?

dravenk commented 2 years ago

but no.... ;(

it doesn't work for all account types ;(

https://outlook.office365.com doesn't work for personal accounts

https://outlook.office.com same....

don;t get why M$ has a problems like this ;(

@dravenk can you check it for office350 and personal accounts?

Yeah. I have only the company's email using office.com, personal using outlook.com. I don't have an MS365 Personal account to test. Not found good documentation about calendar API on microsoft.com. Sorry, no helpful information.

dravenk commented 2 years ago

@gulios @lptn Maybe we cloud check how to add a calendar event for microsoft.com. But I don't have much time to spend on it right now. I created an issue to talk about this feature. https://github.com/spatie/calendar-links/issues/147