spatie / calendar-links

Generate add to calendar links for Google, iCal and other calendar systems
https://spatie.be/opensource
MIT License
914 stars 148 forks source link

Add two required parameters to improve ICS validation #153

Closed makbeta closed 2 years ago

makbeta commented 2 years ago

Context and Purposes

The generated ICS didn't pass validation. I added PRODID & DTSTAMP values per requirements:

alies-dev commented 2 years ago

Hey @makbeta Can you please also update tests? Thanks!

makbeta commented 2 years ago

@lptn My apologies, I am a bit new to this and was rushing, so missed the testing part. Thank you for a kind reminder.

I've created the tests and ran all test locally against the latest code, it all checks out. Will create a new pull request with updates.

P.S. Жыве 🤍 ❤️ 🤍