spatie / calendar-links

Generate add to calendar links for Google, iCal and other calendar systems
https://spatie.be/opensource
MIT License
914 stars 148 forks source link

Add reminder functionality to ICS #178

Closed S-Braeutigam closed 9 months ago

S-Braeutigam commented 1 year ago

Context and Purposes

In the case of ICS format there is no default reminder specified and the person will only be notified exactly when the event takes place. All other calendar options have a default reminder set to 15 minutes before the event, although this might be a setting of the calendar app. To address the issue of a missing reminder before the event we extended the library to allow the setup of a simple default and specified reminder for the ICS format according to the offical specification RFC2245. To be consistent the default reminder is set to 15 minutes before the start date and time of the event, but can be customized using a DateTime and a description can be provided. The reminder is always of type "display" and is not repeated.

alies-dev commented 9 months ago

Hey @S-Braeutigam Great job!

Can you please implement similar functionality for other generators? To follow package principles:

all features should be supported by at least 2 generators (different services have different features)

atymic commented 9 months ago

I had a look and none of the other providers support reminders via URL (they just provide defaults, 30m in case of google, 15m in the case of everyone else). Therefore I think just for ICS is fine as it's the only one without a default reminder