search

spatie / calendar-links

Generate add to calendar links for Google, iCal and other calendar systems
https://spatie.be/opensource
MIT License
914 stars 149 forks source link

Add CLI on the project #52

Closed dorianneto closed 5 years ago

dorianneto commented 5 years ago

Hey dude, how's it going?

Firstly, congrats for your great job on this library, it's helped me a lot in a project.

I know that there are somethings to refactor and others to create, so my suggest is we could view this as a prototype to be validate it.

Recently I needed to create some shell scripts and one of the features is gonna using your library, so I just thought "Why not to create a CLI from the library?". And here is the result.

I created a section in README describing some commands and unit tests were created too.

You can make local testes running the commands with the calendar_links file located in the project root.

If you liked it but you want separate in two independent projects (library and cli) or something like that, let me know so I can help you with that.

Thanks!

alies-dev commented 5 years ago

@dorianneto Thanks for your work! At the moment I don't see any use-cases for a typical use of this package so personally I think this PR a good candidate to extract into a separate package. Having more side-functionality will slow down developing of core functionality, I prefer to focus on core stuff.

But I may miss some uses-cases. Could you please share some use-case you know? Thanks!

alies-dev commented 5 years ago

Closing as inactive with not-passing checks