search

spatie / calendar-links

Generate add to calendar links for Google, iCal and other calendar systems
https://spatie.be/opensource
MIT License
914 stars 149 forks source link

Proper encoding of the payload in data:uri for ics link #72

Closed dogawaf closed 4 years ago

dogawaf commented 5 years ago

When the event's payload contains special url characters, like this one: #, if the data:uri is not properly encoded, the navigator will not correctly navigate to the href: the data:uri will be parsed until the #.

The better solution in that case is to base64 encode the data:uri payload.

dogawaf commented 5 years ago

@lptn I do not update the test snaphosts.

dogawaf commented 5 years ago

Added the updated test snaphosts.

spatie-bot commented 4 years ago

Dear contributor,

because this pull request seems to be inactive for quite some time now, I've automatically closed it. If you feel this pull request deserves some attention from my human colleagues feel free to reopen it.