search

spatie / color

A little library to deal with color conversions
https://spatie.be/opensource/php
MIT License
350 stars 36 forks source link

Forbid strings with text around the color value #22

Closed nesk closed 7 years ago

nesk commented 7 years ago

The #aabbccddee value was considered valid, so I've fixed the behaviour for all color types.

sebastiandedeyne commented 7 years ago

Thanks! Released as 1.1.1.

I had to make one more minor tweak to handle whitespace before and after rgb(a) strings.

https://github.com/spatie/color/commit/60becaca3a2ccf5219ae8159f27cae12ca2c2f91

nesk commented 7 years ago

I wasn't sure about handling whitespaces before and after the value. It's probably better to handle them but what about hexadecimal values? Your minor tweaks only affect rgb and rgba values.

sebastiandedeyne commented 7 years ago

Was doubting about it. The only reason I made the change was so the tests passed, so it was a non-breaking change.