search

spatie / color

A little library to deal with color conversions
https://spatie.be/opensource/php
MIT License
350 stars 36 forks source link

Contrast should return an int or float? #88

Open NiklasBr opened 3 months ago

NiklasBr commented 3 months ago

Function signature says : float https://github.com/spatie/color/blob/2a3bb4e23434cf051cea5467d2e2d9924dd4969f/src/Contrast.php#L7

but the return value is cast to int:

https://github.com/spatie/color/blob/2a3bb4e23434cf051cea5467d2e2d9924dd4969f/src/Contrast.php#L27-L31

It could be improved by changing the return cast to (float), but I am not sure if there are any side effects to I want to ask about what is the intent here before creating a PR.