Help extend the class

[atomixstar]

Hello, I am trying to setup the crawler on laravel but I cannot extend the abstract class, I am sure I am missing something.

App\Abstracts\CrawlLogger.php

`<?php namespace App\Abstracts; use Psr\Http\Message\UriInterface; use Psr\Http\Message\ServerRequestInterface; use Psr\Http\Message\ResponseInterface; use GuzzleHttp\Exception\RequestException;

class CrawlLogger extends CrawlObserver { /* @var string / protected $observerId; public function __construct(string $observerId = '') { if ($observerId !== '') { $observerId .= ' - '; } $this->observerId = $observerId; } /**

• Called when the crawler will crawl the url.
• @param \Psr\Http\Message\UriInterface $url */ public function willCrawl(UriInterface $url) { CrawlerTest::log("{$this->observerId}willCrawl: {$url}"); } /**
• Called when the crawler has crawled the given url.
• @param \Psr\Http\Message\UriInterface $url
• @param \Psr\Http\Message\ResponseInterface $response
• @param \Psr\Http\Message\UriInterface|null $foundOnUrl */ public function crawled( UriInterface $url, ResponseInterface $response, UriInterface $foundOnUrl = null ) { $this->logCrawl($url, $foundOnUrl); } public function crawlFailed( UriInterface $url, RequestException $requestException, UriInterface $foundOnUrl = null ) { $this->logCrawl($url, $foundOnUrl); } protected function logCrawl(UriInterface $url, UriInterface $foundOnUrl) { $logText = "{$this->observerId}hasBeenCrawled: {$url}"; if ((string) $foundOnUrl) { $logText .= " - found on {$foundOnUrl}"; } CrawlerTest::log($logText); } /**
• Called when the crawl has ended. */ public function finishedCrawling() { CrawlerTest::log("{$this->observerId}finished crawling"); } }`

App\Abstracts\CrawlObserver.php

`<?php

namespace App\Abstracts;

use GuzzleHttp\Exception\RequestException; use Psr\Http\Message\ResponseInterface; use Psr\Http\Message\UriInterface; use App\Abstracts\CrawlLogger;

abstract class CrawlObserver { /**

• Called when the crawler will crawl the url.

• @param \Psr\Http\Message\UriInterface $url */ public function willCrawl(UriInterface $url) {

  }

  /**

• Called when the crawler has crawled the given url successfully.
• @param \Psr\Http\Message\UriInterface $url
• @param \Psr\Http\Message\ResponseInterface $response

• @param \Psr\Http\Message\UriInterface|null $foundOnUrl */ abstract public function crawled( UriInterface $url, ResponseInterface $response, UriInterface $foundOnUrl = null );

  /**

• Called when the crawler had a problem crawling the given url.
• @param \Psr\Http\Message\UriInterface $url
• @param \GuzzleHttp\Exception\RequestException $requestException

• @param \Psr\Http\Message\UriInterface|null $foundOnUrl */ abstract public function crawlFailed( UriInterface $url, RequestException $requestException, UriInterface $foundOnUrl = null );

  /**

• Called when the crawl has ended. */ public function finishedCrawling() {

  } }`

Controller:

`.....

use stdClass; use GuzzleHttp\Psr7\Uri; use Spatie\Crawler\Crawler; use Spatie\Crawler\CrawlProfile; use Psr\Http\Message\UriInterface; use Spatie\Browsershot\Browsershot; use Spatie\Crawler\CrawlSubdomains; use Spatie\Crawler\CrawlInternalUrls; use Spatie\Crawler\Exception\InvalidCrawlRequestHandler;

use App\Abstracts\CrawlLogger;

class TestController extends Controller {

public function index() {

    Crawler::create()
    ->setCrawlObserver(new CrawlLogger())
    ->startCrawling('https://github.com');

}

}`

I am getting this error: Type error: Argument 1 passed to Spatie\Crawler\Crawler::setCrawlObserver() must be an instance of Spatie\Crawler\CrawlObserver, instance of App\Abstracts\CrawlLogger given, called in

I am trying to learn how is working and I have search around the web related to extend of classes, but still cannot understand what I am doing wrong.

Thank you :)

[danhunsaker]

One of these classes needs to implements Spatie\Crawler\CrawlObserver - either class in App\Abstracts will do.

[atomixstar]

But in vendor/spatie/crawler/src/CrawlObserver.php is an interface not an abstract class

[danhunsaker]

Right. That's why you implements instead of extends it. That's the purpose of interfaces - for classes to implement.

[d9media-git]

I am sorry but I think that the documentation on the product page is simply misleading because it tells to extend rather than implements. I found this script very hard to implement unfortunately due to poor documentation.

At the moment it reads:

use Spatie\Crawler\Crawler;

Crawler::create()
    ->setCrawlObserver(<class that extends \Spatie\Crawler\CrawlObserver>)
    ->startCrawling($url);

[brendt]

Feel free to submit a PR to fix that typo.

[Googolaire]

I agree the documentation is poor