search

spatie / crawler

An easy to use, powerful crawler implemented in PHP. Can execute Javascript.
https://freek.dev/308-building-a-crawler-in-php
MIT License
2.53k stars 358 forks source link

Tweak variable naming in ArrayCrawlQueue #326

Closed spekulatius closed 4 years ago

spekulatius commented 4 years ago

Hey,

while working with the ArrayCrawlQueue as mentioned in #325, I've noticed the variables being names inconsistent.

Sometimes the passed CrawlUrl was $crawlUrl in other cases $url. The URL string was sometimes $url and other times $urlString.

This PR clears this up and makes it $crawlUrl and $urlString.

Cheers!

freekmurze commented 4 years ago

Thanks!

spekulatius commented 4 years ago

No worries, happy to help!