search

spatie / flysystem-dropbox

A flysystem driver for Dropbox that uses the v2 API
https://freek.dev/734-dropbox-will-turn-off-v1-of-their-api-soon-its-time-to-update-your-php-application
MIT License
343 stars 50 forks source link

use the dropbox provided content hash for flysystem checksum #92

Closed Gummibeer closed 1 year ago

Gummibeer commented 1 year ago

closes #91

freekmurze commented 1 year ago

Thanks!

It seems the tests are failing. Could you take a look at that?

Gummibeer commented 1 year ago

It's the lowest tests failing as the ChecksumProvider interface was added in v3.7 but the package supports thephpleague/flysystem: "^2.0.4 || ^3.0.0", - should the minimum version be bumped? Unsure how else we could fix the problem? And two tests have a warning.

freekmurze commented 1 year ago

Let's bump the minimum versions indeed 👍

Gummibeer commented 1 year ago

@freekmurze done and also fixed the deprecation warning. I assume that this would lead to a new major version of the package? 🤔 As it's BC in several ways.

freekmurze commented 1 year ago

Thanks, I'll tag a new major version indeed.