Closed kevinb1989 closed 9 months ago
PR looks good, thanks! The Trait is usable for other Countries (like Malaysia) too, I assume?
@Nielsvanpach Thanks! And yes, that can be used by any other Asian countries that also use Chinese Calendars.
Thanks!
Holidays in Vietnam According to Wikipedia:
I copied and refactored the
chineseCalendar
method from PR #51 to convert dates from Chinese Calendar to Gregorian one. That becomes theChineseCalendar
trait. We might need that trait for the following countries: