search

spatie / holidays

Calculate which days you don't have to work!
https://spatie.be/open-source
MIT License
329 stars 196 forks source link

Support for Slovenian language second PR after rebase problem #139

Closed juref closed 8 months ago

juref commented 9 months ago

Contributing a new country ?

  1. Create a new class in the Countries directory. It should extend the Country class.
  2. Add a test for the new country in the tests directory.
  3. Run the tests so a snapshot gets created.
  4. Verify the result in the newly created snapshot is correct.
Nielsvanpach commented 9 months ago

PR looks good! I'll wait for some approvals on the generated results before merging.

Nielsvanpach commented 9 months ago

If applicable, I've added support for multi language: https://github.com/spatie/holidays/pull/177

juref commented 9 months ago

Hey, that's great, thanks! I wanted to do PR with this feature, but unfortunately I was admitted to the hospital after an emergency. All well now!

Nielsvanpach commented 8 months ago

Thanks