search

spatie / holidays

Calculate which days you don't have to work!
https://spatie.be/open-source
MIT License
329 stars 196 forks source link

Add Colombian holidays #141

Closed luisprmat closed 9 months ago

luisprmat commented 9 months ago

Contributing a new country ?

Yes, i have checked and I know PR#55 exists for the same country, but it has problems with phpstan. I have rewritten the function that generated problems with types and now the phpstan analysis passes.

PR#55 can be closed in favour of this.

  1. Create a new class in the Countries directory. It should extend the Country class.
  2. Add a test for the new country in the tests directory.
  3. Run the tests so a snapshot gets created.
  4. Verify the result in the newly created snapshot is correct.
Nielsvanpach commented 9 months ago

Could you help https://github.com/spatie/holidays/pull/55 with fixing it instead? Thanks!