spatie / holidays

Calculate which days you don't have to work!

https://spatie.be/open-source

MIT License

329 stars 196 forks source link

Fix::South Sudan Holidays ONLY PR #143

Closed Crawford30 closed 9 months ago

Crawford30 commented 9 months ago

Contributing a new country ?

[Yes ] Have you checked to ensure there aren't other open Pull Requests for the same country?

Create a new class in the Countries directory. It should extend the Country class.
Add a test for the new country in the tests directory.
Run the tests so a snapshot gets created.
Verify the result in the newly created snapshot is correct.

Nielsvanpach commented 9 months ago

Hi, this is still the same as the previous PR. Could you reapply your additions on a clean branch, which started from our latest main branch? This way I don't need to merge all these duplicated commits.