search

spatie / holidays

Calculate which days you don't have to work!
https://spatie.be/open-source
MIT License
329 stars 196 forks source link

Add 🇽🇰Kosovo🇽🇰 Holidays #151

Closed AvdylKrasniqi closed 9 months ago

AvdylKrasniqi commented 9 months ago

TODO: Implement Islamic Holidays

AvdylKrasniqi commented 9 months ago

@Nielsvanpach @thecaliskan @alphaolomi @amralsaleeh @ddouble-d @shoxrux1996 @captainjaypee01 @kakajansh I saw you were involved from other PR about the Islamic Holidays, so I am tagging you here! Perhaps we should all come with a common method in the Country class, so every country can call the method.

ddouble-d commented 9 months ago

@Nielsvanpach @thecaliskan @alphaolomi @amralsaleeh @ddouble-d @shoxrux1996 @captainjaypee01 @kakajansh I saw you were involved from other PR about the Islamic Holidays, so I am tagging you here! Perhaps we should all come with a common method in the Country class, so every country can call the method.

there is one in this PR #51 that implements the islamic calendar

AvdylKrasniqi commented 9 months ago

@Nielsvanpach @thecaliskan @alphaolomi @amralsaleeh @ddouble-d @shoxrux1996 @captainjaypee01 @kakajansh I saw you were involved from other PR about the Islamic Holidays, so I am tagging you here! Perhaps we should all come with a common method in the Country class, so every country can call the method.

there is one in this PR #51 that implements the islamic calendar

I think we should implement a common method for all countries that do have Islamic holidays. On the PR #51 the solution is specifically for Malaysia

thecaliskan commented 9 months ago

Every year the celebration of ramadan and sacrifice holiday's dates are different in Turkey and even inside of the other Islamic countries that's why it's impossible to calculate because the countries are releasing the holiday dates six month ahead not years before.

amralsaleeh commented 9 months ago

Every year the celebration of ramadan and sacrifice holiday's dates are different in Turkey and even inside of the other Islamic countries that's why it's impossible to calculate because the countries are releasing the holiday dates six month ahead not years before.

I'm with you 💯

amralsaleeh commented 9 months ago

So, Is there anything new?

Nielsvanpach commented 9 months ago

In case you want to add multi language support: https://github.com/spatie/holidays/tree/main/lang