Provide optional parameters to Countries

spatie / holidays

Calculate which days you don't have to work!

https://spatie.be/open-source

MIT License

329 stars 196 forks source link

Provide optional parameters to Countries #168

Closed inDeev closed 9 months ago

inDeev commented 9 months ago

This PR allow to provide any required parameters to countries models like region, ethnical type, ...

This PR was created by discussion about North Macedonia holidays Thread here so NorthMacedonia has some preparations made, which will be updated by its contributor

This PR also updating French model and test, as there was problem with custom France constructor just to use region (now it uses global one.

Nielsvanpach commented 9 months ago

I don't think public holidays are based on someone's ethnic?

Nielsvanpach commented 9 months ago

I don't really like this approach, so closing this one. Thanks for your work anyway!

PetrKaterinak commented 9 months ago

@Nielsvanpach Ethnic group is only one of possibilities of this PR, and if it is given by government as discussed in thread mentioned in original PR message, it is valid to have ethnical based holidays.