search

spatie / holidays

Calculate which days you don't have to work!
https://spatie.be/open-source
MIT License
329 stars 196 forks source link

Add Moldavian Holidays #95

Closed vkosachev closed 8 months ago

vkosachev commented 9 months ago

These are Moldavian Holidays, based on the official dates set by the government Reference

Since there was some misunderstanding , the Eastern Orthodox Easter is calculated using Meeus' Julian Algorithm php_realisation

Nielsvanpach commented 9 months ago

There already is a orthodoxEaster() function in Country.php Do you consider that to be a good calculation? If not, why exactly should your calculation be used ad could you provide some tests to verify?

vkosachev commented 9 months ago

There already is a orthodoxEaster() function in Country.php Do you consider that to be a good calculation? If not, why exactly should your calculation be used ad could you provide some tests to verify?

@Nielsvanpach, you're correct. The feature wasn't present when I last updated. It appears to have been included in the a69a226e commit. The base method now performs calculations in a more brief and concise manner. Thanks for pointing that out.

Nielsvanpach commented 9 months ago

In case you need multi language support: https://github.com/spatie/holidays?tab=readme-ov-file#getting-holidays-in-a-specific-language

vkosachev commented 9 months ago

In case you need multi language support: https://github.com/spatie/holidays?tab=readme-ov-file#getting-holidays-in-a-specific-language

Thanks! @Nielsvanpach what is the intention around this ? Is this to support official only languages (defined by law) or just to add support for local minorities?

Nielsvanpach commented 9 months ago

Let's keep it with official languages.

Nielsvanpach commented 8 months ago

Thanks! Feel free to still send a PR with translations.