spatie / holidays

Calculate which days you don't have to work!
https://spatie.be/open-source
MIT License
329 stars 196 forks source link

NYP: added Pakistani holidays and test case #99

Closed NabeelYousafPasha closed 9 months ago

NabeelYousafPasha commented 9 months ago
muhammad-nauman commented 9 months ago

see #19 @Nielsvanpach @NabeelYousafPasha

NabeelYousafPasha commented 9 months ago

Thanks! Did you verify if the generated results in the snapshot are correct?

@Nielsvanpach Yes, I verified those. Snapshot content attached as well.

[ { "name": "Kashmir Solidarity Day", "date": "2024-02-05" }, { "name": "Pakistan Resolution Day", "date": "2024-03-23" }, { "name": "Labour Day", "date": "2024-05-01" }, { "name": "Independence Day", "date": "2024-08-14" }, { "name": "Defence Day", "date": "2024-09-06" }, { "name": "Iqbal Day", "date": "2024-11-09" }, { "name": "Quaid-e-Azam Day", "date": "2024-12-25" } ]

muhammad-nauman commented 9 months ago

@NabeelYousafPasha can you please close this in favor of #19 as per the guidelines? Thanks!

NabeelYousafPasha commented 9 months ago

Closing this PR as https://github.com/spatie/holidays/pull/19 covers Pakistan Holidays.

Thanks @muhammad-nauman for your contribution

muhammad-nauman commented 9 months ago

Thanks @NabeelYousafPasha . Appreciated!