search

spatie / laravel-backup

A package to backup your Laravel app
https://spatie.be/docs/laravel-backup
MIT License
5.61k stars 758 forks source link

Types v9 #1808

Closed rcerljenko closed 2 months ago

rcerljenko commented 2 months ago

Hi,

This happens when you set null on that config in v9:

image

rcerljenko commented 2 months ago

Also, notifications.mail.to used to accept array because Laravel accepts it too in mail handler so you could send notification to multiple emails at once, but now, via config DTO, it only accepts string. :( could that be changed to also accept string|array ?

rcerljenko commented 2 months ago

I made a PR to fix this: https://github.com/spatie/laravel-backup/pull/1809

freekmurze commented 2 months ago

We'll handle this further in the PR