spatie / laravel-link-checker

Check all links in a Laravel application
https://murze.be/2015/11/a-package-to-check-all-links-in-a-laravel-app/
MIT License
259 stars 45 forks source link

method body of MailBrokenLinks@crawlFailed #40

Closed VincentVanWijk closed 6 years ago

VincentVanWijk commented 6 years ago

Im not expirienced with pull requests but the method body of crawlFailed in MailBrokenLinks.php is empty, causing the mail to only contain successfull crawl urls.

I added 2 lines to the method to make it work:

public function crawlFailed(  UriInterface $url,  RequestException $requestException, ?UriInterface $foundOnUrl = null
    ) 
  {
         $url->foundOnUrl = $foundOnUrl;

        return parent::crawlFailed($url, $requestException, $foundOnUrl);
    }

Hope this helps, Vincent van Wijk

freekmurze commented 6 years ago

Will be fixed soon!