spatie / laravel-menu

Html menu generator for Laravel
https://freek.dev/414-a-modern-package-to-generate-html-menus
MIT License
923 stars 82 forks source link

Submenu semantically wrong #88

Closed notflip closed 5 years ago

notflip commented 5 years ago

https://docs.spatie.be/menu/v2/basic-usage/adding-items/#submenus

As you can see the submenu item's are being returned in a separate li

<!-- Wrong: https://docs.spatie.be/menu/v2/basic-usage/adding-items/#submenus  -->
<ul>
    <li>
        <a>item one</a>
    </li>
    <li>
        <ul>
            <li>
                <a>item nested</a>
            </li>
        </ul>
    </li>
</ul>

While the semantic correct version would be.

<!-- Correct -->
<ul>
    <li>
        <a>item one</a>
        <ul>
            <li>
                <a>item nested</a>
            </li>
        </ul>
    </li>
</ul>
freekmurze commented 5 years ago

Could you PR a fix for this? You can create an PR by clicking the edit button on top of the page 👍