spatie / laravel-missing-page-redirector

Redirect missing pages in your Laravel application
https://freek.dev/598-retain-your-seo-worth-by-correctly-redirecting-missing-pages-in-a-laravel-application
MIT License
488 stars 38 forks source link

Use Laravel container on private Router - closes #77 #78

Closed rodrigopedra closed 1 year ago

rodrigopedra commented 1 year ago

closes #77

As the container parameter is nullable in Illuminate\Routing\Router's constructor, an empty container is assigned in its constructor when no container is provided.

Since https://github.com/laravel/framework/pull/44339 introduced Illuminate/Routing/Contracts/CallableDispatcher, a router needs this interface bound to dispatch closure bound routes such as the ones registered here:

https://github.com/spatie/laravel-missing-page-redirector/blob/ba2bc5f2e9cf3be883c311c125c756903eae412d/src/MissingPageRouter.php#L42-L53

This PR

rodrigopedra commented 1 year ago

ping @freekmurze

freekmurze commented 1 year ago

Thanks!