search

spatie / laravel-mix-purgecss

Zero-config Purgecss for Laravel Mix
https://spatie.be/en/opensource
MIT License
874 stars 38 forks source link

Bump Purgecss version to allow support for whitelistPatternsChildren option #30

Closed aryehraber closed 6 years ago

aryehraber commented 6 years ago

This PR simply bumps the underlying purgecss-webpack-plugin version which brings support for a new whitelistPatternsChildren option.

ankurk91 commented 6 years ago

The caret ^ sign in package.json means that you should be able to install 0.22.0 version.

aryehraber commented 6 years ago

Yeah that's what I thought too, however it didn't seem to work; laravel-mix-purgecss would keep using v0.19.0 and thus whitelistPatternsChildren wouldn't be available to me in my Mix config.

ankurk91 commented 6 years ago

Try reinstalling the package, it should pick latest dependencies.

aryehraber commented 6 years ago

I did, a couple of times in fact because I was convinced it should automatically be pulling in the latest version of purgecss-webpack-plugin, but it would keep installing and using v0.19.0.

The only way I was able to resolve it locally was by cding into the package directly (inside node_modules) and run npm i purgecss-webpack-plugin@0.22.

Is it working for you as expected?

sebastiandedeyne commented 6 years ago

The caret ^ sign in package.json means that you should be able to install 0.22.0 version.

No, there's a major version difference because it's still an 0. release.

I'll review and merge this tomorrow 👍

aryehraber commented 6 years ago

A-ha! Didn't know that about 0. releases. Thanks @sebastiandedeyne!

sebastiandedeyne commented 6 years ago

Released a patch version with this PR, thanks!