search

spatie / laravel-model-cleanup

Clean up unneeded records
https://freek.dev/410-a-laravel-package-to-clean-up-models
MIT License
399 stars 42 forks source link

forceDelete() models that use the SoftDeletes trait #39

Closed jochensengier closed 4 years ago

jochensengier commented 4 years ago

Would be great if this got merged, but as always: your package -> your choice.

Thx!

jochensengier commented 4 years ago

I used the ::class notation and made some changes for the tests. Please triple-check and have mercy, I'm not an expert like you in writing tests... 🙈

jochensengier commented 4 years ago

Would you be so kind to have another look at my changes?

freekmurze commented 4 years ago

Code looks good!

Final thing: could you update the readme an add a section on how it behaviour for models with soft deletes?

freekmurze commented 4 years ago

Thanks!

jochensengier commented 4 years ago

Thanks for accepting the PR and for your patience while I struggled with writing the test. I couldn't have done it without your guidance.

freekmurze commented 4 years ago

Thanks for your work on this.